Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wflow ZMQ server: allow JSON reading and writing of NaN and Inf #513

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Wflow ZMQ server: allow JSON reading and writing of NaN and Inf #513

merged 4 commits into from
Dec 18, 2024

Conversation

vers-w
Copy link
Collaborator

@vers-w vers-w commented Dec 3, 2024

Issue addressed

Fixes #392

Explanation

See issue #392

vers-w added 3 commits December 3, 2024 11:49
@vers-w
Wflow server: allow JSON reading and writing of NaN and Inf
410995c 
By setting `allow_inf` arg to `true`.
@vers-w
Add small server test
43e4382 
To test if `NaN` values are allowed.
@vers-w
Update changelog
f860bbc
@vers-w vers-w self-assigned this Dec 3, 2024
@vers-w vers-w requested a review from JoostBuitink December 18, 2024 07:18
JoostBuitink
JoostBuitink approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@JoostBuitink JoostBuitink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (note: did not test the code myself, but the implementation looks straightforward and good)!

@vers-w vers-w merged commit ecca90a into master Dec 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoostBuitink JoostBuitink JoostBuitink approved these changes

Assignees

@vers-w vers-w

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wflow ZMQ Server: BMI.getvalue can throw JSON spec error
2 participants
@vers-w @JoostBuitink